Add Brush classes #689
Merged
Add Brush classes #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits sharing of gradients between brushes, and also the potential to grow a better Gradient api in the future - eg. adding methods for formal operations that keep gradient invariants preserved: add stop, remove stop, reverse, etc.
jwiggins
reviewed
Mar 7, 2021
This also shows examples of using overlays and tools.
|
There's bits of the gradient example which could be pulled out and either added to the gradient object itself, or turned into more general things. But for now an example is good enough. |
jwiggins
reviewed
Mar 8, 2021
jwiggins
approved these changes
Mar 8, 2021
jwiggins
reviewed
Mar 8, 2021
|
Assuming that tests pass, this is good to go. |
jwiggins
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are classes intended to make it easier to paint and style filled regions. This PR simply adds the classes and an example of usage.
Subsequent PRs will integrate this into existing code (eg. to add a background brush class to the base component).