Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "use_draw_order" code path #777

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Remove "use_draw_order" code path #777

merged 2 commits into from
Apr 16, 2021

Conversation

aaronayres35
Copy link
Contributor

@aaronayres35 aaronayres35 commented Apr 15, 2021 •
edited

fixes #775

See corresponding issue/PR in chaco: enthought/chaco#659, enthought/chaco#671

This PR simply removes the now unneeded check of use_draw_oder and simply fills the body of dispatch with what used to be _new_dispatch. _old_dispatch is deleted.

rahulporuri
rahulporuri approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment - can you fix the reference to _new_dispatch and _old_dispatch in the enable documentation as well?

@rahulporuri
Copy link
Contributor

Still LGTM

@aaronayres35 aaronayres35 merged commit a1a6059 into master Apr 16, 2021
@aaronayres35 aaronayres35 deleted the remove-use_draw_order branch April 16, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the now unnecessary "use_draw_order" code path?
2 participants
@aaronayres35 @rahulporuri