Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #786

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Remove dead code #786

merged 2 commits into from
Apr 20, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR

  • removes support for older versions of wx (< 3)
  • removes unnecessary files
  • removes unnecessary readmes or update readmes
  • removes commented out code and code paths
  • removes KIVA_WISHLIST handling in kiva init

- remove support for older versions of wx
- remove unnecessary files
- remove unnecessary readmes or update readmes
- remove commented out code and code paths
- remove KIVA_WISHLIST handling in kiva init

	deleted:    docs/kiva/agg/interface.txt
	modified:   enable/savage/svg/backends/wx/renderer.py
	modified:   enable/wx/base_window.py
	modified:   enable/wx/constants.py
	modified:   kiva/__init__.py
	deleted:    kiva/agg/src/dummy.cpp
	modified:   kiva/agg/src/kiva_gradient.h
	modified:   kiva/agg/src/kiva_graphics_context.h
	modified:   kiva/agg/src/numeric_ext.i
	modified:   kiva/agg/src/readme.txt
	deleted:    kiva/agg/src/tst_convert.py
	deleted:    kiva/fonttools/README.rst
	modified:   kiva/gl/src/kiva_gl_graphics_context.cpp
	deleted:    kiva/readme.txt
	deleted:    kiva/tests/agg/README.txt
@rahulporuri rahulporuri added this to In progress in Enthought OSS Q2 2021 Apr 20, 2021
	modified:   kiva/agg/agg.i
	modified:   kiva/gl/gl.i
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit efa8576 into master Apr 20, 2021
@rahulporuri rahulporuri deleted the cln/remove-dead-code branch April 20, 2021 15:21
@rahulporuri rahulporuri moved this from In progress to Done in Enthought OSS Q2 2021 Apr 20, 2021
@rahulporuri rahulporuri moved this from Done to Sprint 2 : 19 April - 30 April 2021 in Enthought OSS Q2 2021 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q2 2021
  
Sprint 2 : 19 April - 30 April 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants