Skip markers tests if not using agg #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
moved this from Done
to Sprint 2 : 19 April - 30 April 2021
in Enthought OSS Q2 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test was skipped when not on qt. This worked because it avoided the scenario of using quartz as tthe default backend on wx. See:
https://github.com/enthought/traits/blob/249d64813b633390616af4e57ceb19a553c250ef/traits/etsconfig/etsconfig.py#L313-L320
Realistically, these tests are specific to the old agg. see comment: #782 (comment)
Note we can't yet skip if not "oldagg" because oldagg isn't actually used yet. Doing so the test would no longer be run. I left a comment to replace 'image' with 'oldagg' in the
skipIfonceimageuses celiagg.