-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix artefact in Qt caused by QRectF having a slightly wrong size #820
Conversation
@jwiggins any chance you can make time to review this PR today/monday? It looked good to me but i wanted a more experienced pair of eyes. The idea is to make a bug fix release ASAP once this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review and testing! |
Closes #819
The issue is tested (manually) to affect these backends:
qt4.image
,qt4.celiagg
andqt4.cairo
.For these backends, the
GraphicsContext
is defined to be slightly larger than the requested size:enable/enable/qt4/cairo.py
Lines 20 to 23 in 1c3805c
There is another
QRectF
defined forqt4.quartz
, but I could not reproduce the issue there. For this backend, the GraphicsContext was defined without the plus-one:enable/enable/qt4/quartz.py
Line 35 in 6850385
Note that
base_scale
was not defined on theGraphicsContext
for the cairo backend, and so it has to be added.Apparently
base_scale
is not defined on theqpainter
'sGraphicsContext
either, but that would be an orthogonal issue as #819 does not affect theqpainter
backend.