This repository has been archived by the owner on May 24, 2021. It is now read-only.
Sync enaml with chaco #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaco/enaml are using the same toolkit.
| enaml_toolkit = 'wx' if toolkit_option == 'wx' else 'qt' | ||
| os.environ['ETS_TOOLKIT'] = 'wx' if enaml_toolkit == 'wx' else 'qt4' | ||
| else: | ||
| if enaml_toolkit != 'default': |
There was a problem hiding this comment.
enaml_toolkit appear to be an undefined local if this else block executes.
Make the logic in prepare_toolkit a bit easier to follow.
fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr re-introduces the logic to overcome issue #168
With this
enaml-runwill behave as follows.ETS_TOOLKITis set and the--toolkitoption is notenaml-runwill respectETS_TOOLKITvalue and use the related backed.ETS_TOOLKITis set and the--toolkitoption is set to an incompatible backend then a warning israised, but
enaml-runwill still honor the--toolkitoption.ETS_TOOLKITis not set thenenaml-runwith temporarily set the compatible backend in os.environ so that chaco and enaml components are in sync.