Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTD_Using_Eggs example is broken. #329

Closed
rahulporuri opened this issue Oct 21, 2020 · 0 comments · Fixed by #557
Closed

MOTD_Using_Eggs example is broken. #329

rahulporuri opened this issue Oct 21, 2020 · 0 comments · Fixed by #557

Comments

@rahulporuri
Copy link
Contributor

The MOTD_Using_Eggs example is broken at the moment.

After fixing namespace package-related issues (which needed updates to setup.py and the package layout), I was able to build eggs and move them to the expected location. But, in the end, this was not enough as the EggPluginManager was unable to discover the eggs in the dist\eggs directory - eggs which have not been installed into the environment. The EggPluginManager seems to only discover entry points/contributions from packages installed in the environment.

Before anyone endeavours to fix the broken example, we should consider whether or not it is worth fixing in the first place.

mdickinson added a commit that referenced this issue Mar 23, 2023
[Includes commits from #556]

This PR cleans up our legacy examples, either deleting them or making
them work:

- Makes the `AcmeLab` workbench-based example work again, primarily by
fixing Python 2 relative imports.
- Removes two egg-based demos: `AcmeLabUsingEggs` and `MOTD_Using_Eggs`.
- Removes the `Lorenz` demo, which uses parts of Chaco that no longer
exist (`ChacoPlotItem`)
- Fixes `flake8` issues (mostly unused imports and missing copyright
headers) in remaining examples
- Removes the `examples` directory exclusion from the `.flake8`
configuration file

Closes #381 
Closes #361
Closes #329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant