Add failing test and fix for old-style relative import. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's failing, but for the wrong reasons. Yep, we've got bigger problems. |
|
😱 |
|
Okay, CI is now fixed, but is no longer running IPython-related tests (#113). Closing this PR for now: it's not useful to have it open while the IPython-related stuff is fixed. |
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 36.25% 36.26% +0.01%
==========================================
Files 199 199
Lines 6278 6278
Branches 698 698
==========================================
+ Hits 2276 2277 +1
+ Misses 3927 3926 -1
Partials 75 75
Continue to review full report at Codecov.
|
|
This is the correct failure now, right? |
|
PR reopened; test failing as expected. Now we can fix it! |
|
Voilà! |
|
@jwiggins Since you're watching this, care to do a quick review? |
mdickinson
changed the title
|
Yup. LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a PR containing just a failing test (for #108). If this PR doesn't fail (initially) then we've got bigger problems.
Fixes #108.