-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failing test and fix for old-style relative import. #109
Conversation
It's failing, but for the wrong reasons. Yep, we've got bigger problems. |
😱 |
Okay, CI is now fixed, but is no longer running IPython-related tests (#113). Closing this PR for now: it's not useful to have it open while the IPython-related stuff is fixed. |
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 36.25% 36.26% +0.01%
==========================================
Files 199 199
Lines 6278 6278
Branches 698 698
==========================================
+ Hits 2276 2277 +1
+ Misses 3927 3926 -1
Partials 75 75
Continue to review full report at Codecov.
|
This is the correct failure now, right? |
PR reopened; test failing as expected. Now we can fix it! |
Voilà! |
@jwiggins Since you're watching this, care to do a quick review? |
Yup. LGTM |
Thanks! |
Creating a PR containing just a failing test (for #108). If this PR doesn't fail (initially) then we've got bigger problems.
Fixes #108.