Cleanup Release Issue Template #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you're using VS Code, there is a "Preview" option that will render the markdown in the editor. That should make it easier to experiment rather than pushing the changes to github and seeing how GitHub renders it.
that icon should be visible in the top-right corner of the editor. Ref https://code.visualstudio.com/Docs/languages/markdown#_dynamic-previews-and-preview-locking |
This is extremely useful, thank you! |
rahulporuri
approved these changes
Nov 25, 2020
| - [ ] Open and merge a PR against `maint/<release version number>` | ||
| - [ ] Create a new branch from `maint/<release version number>`, Flip `IS_RELEASED` back to false, commit. | ||
| - [ ] Open and merge another PR against `maint/<release version number>` | ||
| - [ ] Tag (annotated!) the release candidate on the commit where IS_RELEASED is set to true, e.g. `git tag -a -m "Release candidate <release version number>rc1" <release version number>rc1 <commit-hash>` | ||
| - [ ] Push the tag to GitHub | ||
| - [ ] Upload to PyPI | ||
| - `git checkout <tag>`, `git clean -ffxd`, `python setup.py sdist`, `twine check dist/<...>.tar.gz`, `twine upload dist/<...>.tar.gz` |
There was a problem hiding this comment.
The Release blockers section doesn't get rendered correctly because it's just - [ ]. It might be useful to add a few words there.
rahulporuri
reviewed
Nov 25, 2020
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
rahulporuri
moved this from Done
to Sprint 4 : Nov 16 - Nov 27 2020
in Enthought OSS Q4 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply tries to clean up some markdown issues in the newly added release checklist issue template.
motivated by this comment: #371 (comment)