Port changes from upstream QVTKRWI. #1300
Conversation
prabhuramachandran
force-pushed
the
update-qt-interactor
branch
from
7e3e3b4
to
d5b9551
Compare
|
The Then ideally some merge requirements could be set for the CIs (i.e., allow "merge when green" button clicking). The other failure is probably an issue with PySide 6.7 so you could pin to |
- Thanks to @larsoner for help with the macos-latest issue. - The test failure seems some strange issue with recent PySide6 versions all the way back to 6.6.2.
Thanks, I am trying that now.
Yes, the interface expects some tests in the last week so I wasn't able to add those.
It fails even with older versions and looks to be a bit bizarre. For now I am skipping this test with pyside6. Can you please review the PR. |
|
@larsoner -- could you please review the PR once so I can merge this and start the release? |
| @@ -787,4 +794,5 @@ def _qt_key_to_key_sym(key): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| print(PyQtImpl) | |||
There was a problem hiding this comment.
Did you forget to delete debug print output?
| print(PyQtImpl) |
There was a problem hiding this comment.
This is part of the original upstream version and is in the __main__ block so I think it is fine as it is convenient when debugging without having to edit the source.
|
I would merge, but it looks like my approval is insufficient to enable the green button |
@dpinte @mdickinson any ideas on how this could be done? |
|
Hi @prabhuramachandran. I've (temporarily?) disabled the "Require approvals" settings in the branch protections for master, so that this PR can be merged. We should discuss (possibly by email) a longer-term solution. |
We has set up a GitHub Bot so that when an admin user makes an LGTM comment on a PR of which they are the author, the GitHub Bot approves that PR. This allows admins to merge their PRs as they wish, while leaving the rule that admins approve other PRs. |
Thank you, yes let us discuss this via email. For now this is fine. |
|
@tkoyama010 -- Thank you for the offer. I am not sure about this and how this would work. Let me first discuss this and let you know. Thank you for the kind offer though. |
Email sent ... Let me know if you didn't receive anything. |
Got it, thank you. Sorry for the slow response. |
This ports several changes from upstream as a result this works well with PyQt6.