Fix for unexpected test code #374
Conversation
Fix for a few strange things. The dictionary is changed in place, so it must be copied. Additionally, it's probably supposed to call tearDown, not setUp()
|
Can you specify which tests fail, if possible? |
|
This one, but it only fails on OSX for some reason. |
| else: | ||
| for engine in registry.engines: | ||
| for engine in registry.engines[:]: |
There was a problem hiding this comment.
You meant list(registry.engines)?
There was a problem hiding this comment.
@kitchoi it's the same, but I just realized it's a dictionary, not a list.
|
|
Current coverage is 45.51%@@ master #374 diff @@
==========================================
Files 254 254
Lines 22885 22885
Methods 0 0
Messages 0 0
Branches 3027 3027
==========================================
Hits 10414 10414
Misses 11756 11756
Partials 715 715
|
| @@ -211,29 +211,29 @@ def test_colorbar(self): | |||
| ################################################################################ | |||
| class TestMlabPipeline(TestMlabNullEngine): | |||
| """ Test the pipeline functions. | |||
| For vtk versions greater than 5.6 (5.10.1 onwards), widgets need | |||
| For vtk versions greater than 5.10.1, widgets need | |||
There was a problem hiding this comment.
I think we can safely assume that patchlevel is irrelevant (hopefully)
There was a problem hiding this comment.
I agree. So perhaps 5.10 onwards is more true to the implementation in the code.
|
Failure seems unrelated, restarting. |
|
Assuming tests would pass with Linux + 5.10 (as it does with Mac), it looks good to me |
|
Tested on 5.10 ubuntu, seems to work. Merging. |
Fix for a few strange things. The dictionary is changed in place, so it must be copied.
Additionally, it's probably supposed to call tearDown, not setUp()