Notebook Python 3 fixes #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use next() rather than .next() which doesn't exist on Python 3
Current coverage is 45.61% (diff: 25.00%)@@ master #417 diff @@
==========================================
Files 256 256
Lines 23292 23293 +1
Methods 0 0
Messages 0 0
Branches 3074 3074
==========================================
+ Hits 10623 10624 +1
Misses 11948 11948
Partials 721 721
|
Base64 decoding is more complicated on Python 3 due to it's sensitvity with bytes. Thus, use the base64 module and ensure that the output is re-encoded as ascii otherwise Python 3 outputs a 'b' prefix
patricksnape
changed the title
|
Thanks for this! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next()rather than.next()which doesn't exist on Python 3.base64module forpngbackend.