Fix numpy warnings. #541
Merged
Fix numpy warnings. #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will show up with numpy version >= 1.12 when the mlab.view function is called with distance and focal point set to arrays. Thanks to @FedeMiorelli for finding this issue and suggesting a fix.
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
- Coverage 52.42% 52.42% -0.01%
==========================================
Files 255 255
Lines 22600 22603 +3
Branches 3020 3021 +1
==========================================
+ Hits 11849 11850 +1
- Misses 10020 10021 +1
- Partials 731 732 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show up with numpy version >= 1.12 when the mlab.view function
is called with distance and focal point set to arrays. Thanks to
@FedeMiorelli for finding this issue and suggesting a fix. Supersedes #509.