Fix support for wxPython 3.0 #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retains compatibility with 2.8 - there wx.InitAllImageHandlers() is a no-op, wx.HIDE_READONLY is 0, and wx.PySimpleApp() issues a deprecation warning. Patch originally by Olly Betts <olly@survex.com>
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
=======================================
Coverage 50.86% 50.86%
=======================================
Files 263 263
Lines 23843 23843
Branches 3251 3251
=======================================
Hits 12128 12128
Misses 10928 10928
Partials 787 787
Continue to review full report at Codecov.
|
|
Looks fine to me but I haven't used the wxPython backend in ages. Does this work with wxPython 4.x? |
|
These changes should be compatible with wxPython 4.x, yes. I haven't tested it with wxPython 4.x and there are likely other changes required to make it work with 4.x. |
|
Thanks, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retains compatibility with 2.8 - there wx.InitAllImageHandlers() is a no-op,
wx.HIDE_READONLY is 0, and wx.PySimpleApp() issues a deprecation warning.
Patch originally by Olly Betts olly@survex.com