New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug report: image_volume.py time_stamp breaks reproducible builds #1254
Comments
Thanks for the report, although I don't think this is an issue with Pyface. I'm not sure why your build is touching the icons.zip file. You should be able to treat that as a fixed asset from the point of view of linux packaging. |
It seems, icons.zip is modified by the unittests: |
Yes, I think there are tests which test the correct regeneration of the zip archives. Tests shouldn't be run on as part of actually creating a build artefact though? I'd think you'd want to run the tests on the result of the reproducible build. |
This seems to be an effect of how we build with |
We solved it now via https://build.opensuse.org/request/show/1131679 by copying PYTHONPATH / |
Environment
OS: all (openSUSE-Tumbleweed-20230728)
Python version: all
Description
While working on reproducible builds for openSUSE, I found that
building our
python-pyface
package twice resulted in such diffs:There should be a way to get deterministic build results, e.g. allow to override the build timestamp with
SOURCE_DATE_EPOCH
.Steps to Reproduce
do a clean build twice
The text was updated successfully, but these errors were encountered: