New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows build and update to QuantLib 1.4 #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ql/settings.hpp to be used locally when in dll context
quantlib/settings/)
Fixes #1 |
Closed
Builds and tests ok on OSX and Linux. Failure on Windows for :
Numerical errors can be investigated in a separate PR. |
Awesome! I can build this on Windows 7 during the weekend, if you want. |
@jvkersch Next test is Win7 64bit. 32bit runs fine. If you can look into that, that's great. |
dpinte
added a commit
that referenced
this pull request
Sep 11, 2014
Fix windows build and update to QuantLib 1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes with a real solution for the Singleton issue on Windows. It also updates the code to use QuantLib 1.4.
! Builds instructions are not updated yet. This code uses a QuantLib dll that must be built with the symbol.def file attached to this PR and a very small path on ql/settings.hpp (dllexport on the Settings class).
This PR requires testing on Win64 and non-windows platforms