Added Python 3 compatibility #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default encoding by HTML supplier is UTF-8, and we never set it to anything else.
The container is modified during iteration, so ensure we're working on a copy on both python 2 and 3.
Failed previously for such statements as `python -m rested.app`.
Closed
|
Thanks for doing this @vidartf ! Will try to take a look in the next few days... |
| @@ -43,4 +43,6 @@ def main(): | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
| if __package__ is None: | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the clarification. Wasn't aware of that pep.
|
Quick usability test on Python2.7 and Python 3.5 was successful. |
|
LGTM. Thanks! |
|
Will merge today if no more comments come in. |
jonathanrocher
pushed a commit
that referenced
this pull request
Feb 12, 2016
Added Python 3 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the codebase compatible with Python 3. There might still be some string encoding issues left (always hard to track down), but as far as I can see this works as it should.