Use unittest to discover and run the testsuite instead of nose #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 25, 2021 13:55
this way, unittest discover would also pick up the test instead of solely relying on nose modified: scimath/units/tests/test_dimensionless_units.py
modified: scimath/units/tests/test_scalar_unit.py
by unittest discover modified: scimath/units/tests/test_dimensionless_units.py
modified: etstool.py
modified: etstool.py
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 65.71% 65.71%
=======================================
Files 60 60
Lines 2870 2870
Branches 369 369
=======================================
Hits 1886 1886
Misses 892 892
Partials 92 92 Continue to review full report at Codecov.
|
aaronayres35
approved these changes
Jun 28, 2021
rahulporuri
moved this from In progress
to Sprint 6 : 14 June - 25 June 2021
in Enthought OSS Q2 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following :
dimensionless_testinto a test method in aunittest.TestCaseclasstest_instead of ending with_testto ensure that it gets picked up during unittest test discoveryunittest discoverinstead of nose to discover and run the testsuitenoseas a dependency in the etstool utility