BUG: Clean up NameErrors. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these are obvious typos and refactoring leftovers. There are still a few in `scimath.physical_quantities` because that package looks like unfinished work. Fixes #51 (or what I can of it).
mdickinson
reviewed
Oct 4, 2018
| @@ -108,6 +108,7 @@ def get_family_format_from_file(self, filename=None): | |||
| # manager). | |||
|
|
|||
| is_data = False | |||
| column_names = [] | |||
There was a problem hiding this comment.
With this change, can we drop the later column_names = [] (around line 142)?
mdickinson
reviewed
Oct 4, 2018
| @@ -201,6 +203,8 @@ def get_family_ranges_from_file(self, filename=None): | |||
| # manager). | |||
|
|
|||
| is_data = False | |||
| column_names = [] | |||
| system_names = [] | |||
There was a problem hiding this comment.
Same question here: can we drop the initialization of column_names and system_names in the else block below?
There was a problem hiding this comment.
I left them to ensure that they do get (re?)set in that else: block. That else: block ought to be executed before any other branch that needs those values, and only once, but we're doing I/O, so it's never certain.
There was a problem hiding this comment.
I think it is certain in this case: the elif block can't run before the else does (because is_data doesn't become true until the else block runs), and the top if doesn't care.
mdickinson
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these are obvious typos and refactoring leftovers. There are still
a few in
scimath.physical_quantitiesbecause that package looks likeunfinished work.
Fixes #51 (or what I can of it).