Add Enaml regression tests. #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR, since the corresponding Enaml PR was rejected: Please remember to delete the Qt controls by hand if you are for example embedding an Enaml view in an external Qt application (e.g. pyface.tasks). At a minimum, you need to remove all strong references to the UI control so that the widgets can be garbage collected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enaml does not define tests, but on the other hand we need to make sure that the core content remains stable for our applications. This PR defines a new sub-package,
enaml_tests, where we can store regression tests againstenamlitself.The first test defined here tests that the
destroymethod in QtToolkitObject deletes the Qt widget. This currently fails, and I filed a PR in Enaml to fix it.Please only merge when Enaml is fixed.