Skip to content

Commit

Permalink
Fix missing 'self' in method definition (#426)
Browse files Browse the repository at this point in the history
`BaseTask.run` was missing its first `self` argument. This didn't actually affect any code, since the base class method is never called (it's only there as a placeholder to be overridden by subclasses), and all the subclasses have the correct signature.
  • Loading branch information
mdickinson committed Jul 16, 2021
1 parent 79e0b3e commit ea65fa9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion traits_futures/base_future.py
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ class BaseTask:
for execution of the background task and sending of any custom messages.
"""

def run(send, cancelled):
def run(self, send, cancelled):
"""
Run the body of the background task.
Expand Down

0 comments on commit ea65fa9

Please sign in to comment.