-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Rework toolkit support #299
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the top-level traits_futures.api
….optional_dependencies; get rid of the api module
…adingContext optional
Done in #319. |
The final piece of this PR has been recreated as #321. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a fairly large amount of refactoring and renaming, but its focus is on reworking the toolkit support.
The main goals are:
multithreading_router
made use of the toolkit machinery, for example.EDIT 2021-04-28: Most of the real content of this PR has now been extracted into separate PRs (all of which have been merged): #306, #307, #308, #309, #312, #314, #315
What's left is:
GuiTestAssistant
to use the asyncio tests by default instead of the ETS toolkit. That is a change I want to make, but I'd be happier if we had toolkit-specific tests for theEventLoopHelper
first, otherwise we risk some of that code going untested. (Done in Add tests for each of the IEventLoopHelper implementations #319.)The
EventLoopHelper
may need to grow some new methods, for example a thread-safe method that sets a trait later, when the event loop is running. (Also done in #319.)