New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a test that returned an exception instead of a result #508

Merged

mdickinson merged 2 commits into main from fix-returning-exception-in-test

Oct 17, 2022

Member

mdickinson commented Sep 30, 2022

This PR fixes a test that uses _task_returned to return an exception rather than a result.

The test works, but it's potentially confusing: there's no good reason for it to be returning exception information instead of a result.


          Fix a test that returned an exception instead of a result

33fe1a7

rahulporuri approved these changes

View reviewed changes


          Merge branch 'main' into fix-returning-exception-in-test

11ee200

mdickinson merged commit bca1f2d into main

mdickinson deleted the fix-returning-exception-in-test branch

October 17, 2022 08:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment