-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove traits_super #1015
Remove traits_super #1015
Conversation
Unrelated note: Thanks to the checklist which reminded me of the docs and annotations. I had initially forgotten! |
@@ -41,7 +41,6 @@ Classes | |||
|
|||
.. autoclass:: ISerializable | |||
|
|||
.. autoclass:: traits_super |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to lose another blank line here?
(I had to find something to complain about. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! (Who knows if I deliberately left it there for it to be complained about ;) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, CI permitting
Still LGTM! |
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
==========================================
+ Coverage 74.61% 74.81% +0.20%
==========================================
Files 51 51
Lines 6457 6449 -8
Branches 1279 1279
==========================================
+ Hits 4818 4825 +7
+ Misses 1271 1253 -18
- Partials 368 371 +3
Continue to review full report at Codecov.
|
Closes #1013
This PR removes
traits_super
.Checklist
Tests: Never tested.docs/source/traits_api_reference
)Update User manual (: Never mentioneddocs/source/traits_user_manual
)traits-stubs