Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traits_super #1015

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Remove traits_super #1015

merged 4 commits into from
Apr 17, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Apr 17, 2020

Closes #1013

This PR removes traits_super.

Checklist

  • Tests: Never tested.
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual) : Never mentioned
  • Update type annotation hints in traits-stubs

@kitchoi
Copy link
Contributor Author

kitchoi commented Apr 17, 2020

Unrelated note: Thanks to the checklist which reminded me of the docs and annotations. I had initially forgotten!

@@ -41,7 +41,6 @@ Classes

.. autoclass:: ISerializable

.. autoclass:: traits_super
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to lose another blank line here?

(I had to find something to complain about. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! (Who knows if I deliberately left it there for it to be complained about ;) )

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI permitting

@mdickinson
Copy link
Member

Still LGTM!

@codecov-io
Copy link

codecov-io commented Apr 17, 2020

Codecov Report

Merging #1015 into master will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   74.61%   74.81%   +0.20%     
==========================================
  Files          51       51              
  Lines        6457     6449       -8     
  Branches     1279     1279              
==========================================
+ Hits         4818     4825       +7     
+ Misses       1271     1253      -18     
- Partials      368      371       +3     
Impacted Files Coverage Δ
traits/api.py 90.32% <ø> (ø)
traits/has_traits.py 72.40% <ø> (+0.23%) ⬆️
traits/editor_factories.py 79.59% <0.00%> (-9.19%) ⬇️
traits/trait_type.py 77.21% <0.00%> (-0.64%) ⬇️
traits/trait_types.py 72.31% <0.00%> (-0.15%) ⬇️
traits/trait_handlers.py 61.11% <0.00%> (+0.42%) ⬆️
traits/traits.py 76.63% <0.00%> (+4.09%) ⬆️
traits/etsconfig/etsconfig.py 63.46% <0.00%> (+6.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2685c7a...da98cc7. Read the comment docs.

@kitchoi kitchoi merged commit 12f0bd6 into master Apr 17, 2020
@kitchoi kitchoi deleted the 1013-del-traits-super branch April 17, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove traits_super
3 participants