Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TraitSetEvent arguments keyword-only #1036

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Make TraitSetEvent arguments keyword-only #1036

merged 1 commit into from
Apr 27, 2020

Conversation

mdickinson
Copy link
Member

This PR makes the TraitSetEvent arguments keyword-only, for safety, and for consistency with TraitDictEvent. I'd like to do the same for TraitListEvent too, but that needs changes in TraitsUI. See #1035

Checklist

  • Tests

@kitchoi kitchoi self-requested a review April 27, 2020 14:28
kitchoi
kitchoi approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi
Copy link
Contributor

kitchoi commented Apr 27, 2020

See enthought/traitsui#795

@kitchoi kitchoi merged commit d48e4fc into master Apr 27, 2020
@kitchoi kitchoi deleted the cln/trait-set-event-kw-only branch April 27, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitchoi kitchoi kitchoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdickinson @kitchoi