Relax immutability in NamedTraitObserver for consistency #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FTR, I'd prefer keeping this protection, but consistency is more important. |
Okay; can you explain why? Maybe I'm missing something. Do you consider this particular bit of code in special need of protection? Do you think we should have this level of protection everywhere in the codebase, or is it just here that it's particularly important? |
|
I am wiling to bring about this change, and I rate this less important than consistency. I just mean not to take credit for the change, that is all. I am sorry for the confusion. |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListItemObserverdoes not prevent its attributes to be mutated (see #1071). For consistency, this PR relaxes the protection onNamedTraitObservertoo.These attributes should not be mutated despite this change.
Checklist
Update API reference (docs/source/traits_api_reference)Update User manual (docs/source/traits_user_manual)Update type annotation hints intraits-stubs