Rename the changed object as 'object' in all events #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitchoi
changed the title
kitchoi
commented
May 19, 2020
| @@ -21,9 +21,11 @@ class DictChangeEvent: | |||
| "*name* _items" trait. In particular, the attribute ``changed`` is not | |||
| defined here. | |||
|
|
|||
| The interface of this object is provisional as of version 6.1. | |||
There was a problem hiding this comment.
If we keep this sentence, I will open a separate issue for removing this again when the interface is no longer provisional.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1084
This PR makes
objectexist in all 4 event objects in observe.Checklist
docs/source/traits_api_reference): updated docstringUpdate User manual (docs/source/traits_user_manual)Update type annotation hints intraits-stubs