Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose expressions for observing traits with filters #1112

Merged
merged 8 commits into from
May 19, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented May 19, 2020

Part of #977

This PR:

  • Add metadata in the expression for observing traits with a given metadata name
  • Implement the parsing of "+metadata_name" in the mini-language
  • Add match in the expression for wrapping the FilteredTraitObserver, useful for use cases not supported by the other expressions.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference): autodoc handles that
  • Update User manual (docs/source/traits_user_manual): Will be in a separate PR
  • Update type annotation hints in traits-stubs

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi kitchoi merged commit 78bc0d9 into master May 19, 2020
@kitchoi kitchoi deleted the 977-metadata-expression branch May 19, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants