Fix Union to use default_value for setting static default #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1104
This PR makes
Unionusedefault_valueinstead ofdefaultfor defining static default. This name is consistent with other trait types.Unfortunately
Eitherusesdefaultinstead and is an anomaly. In order to help downstream code migrates, an error is raised if a metadata named'default'is found.Expanded user manual to mention the different naming used for static defaults in
EitherandUnion.Checklist
Update API reference (docs/source/traits_api_reference)docs/source/traits_user_manual)Update type annotation hints in: default_value is not mentioned theretraits-stubs