Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for a list length violation #1173

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

mdickinson
Copy link
Member

Fix an error message that was mistakenly using the built-in type object in place of the HasTraits object that the trait lives on.

Fixes #1170

Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 41fad6a into master Jun 2, 2020
@mdickinson mdickinson deleted the fix/list-length-violation-error-message branch June 2, 2020 08:36
mdickinson added a commit that referenced this pull request Jun 2, 2020
* Fix error message for a list length violation

* Update changelog entry

(cherry picked from commit 41fad6a)
mdickinson added a commit that referenced this pull request Jun 2, 2020
* Fix error message for a list length violation (#1173)

* Fix error message for a list length violation

* Update changelog entry

(cherry picked from commit 41fad6a)

* Ensure length check on unconstrained list always passes (#1172)

* Ensure length check on unconstrained list always passes

* Add changelog entry

* Same fix for __delitem__

(cherry picked from commit 4dca1f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TraitListObject._validate_length has bad error message
2 participants