Don't mutate global state at import time in a test module #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reviewing! |
mdickinson
added a commit
that referenced
this pull request
Jul 21, 2020
(cherry picked from commit 24345a1)
mdickinson
added a commit
that referenced
this pull request
Jul 21, 2020
* Fix end-year in copyright statement (#1198) (cherry picked from commit 21e2a99) * Fix trait-documenter extension tests for Sphinx 3.1 (#1206) (cherry picked from commit aeaf72f) * DOC/FIX: User manual mentioning a nonexisting feature in metadata filter (#1207) * Fix user manual erroneously mentioning a nonexisting feature * Fix grammar Co-authored-by: Mark Dickinson <mdickinson@enthought.com> Co-authored-by: Mark Dickinson <mdickinson@enthought.com> (cherry picked from commit 3e78a41) * Spelling and grammar. (#1210) (cherry picked from commit 24c4d76) * Fix description in README to match the one in the setup script (#1219) (cherry picked from commit a5dc3f2) * Fix some missing stubs (#1204) * Add a couple of missing imports to api.pyi * Remove mis-spelled stubs file * Add missing api.pyi stubs for the has_traits module * Add CTrait * Add imports for BaseTraitHandler and TraitHandler * Add constants (cherry picked from commit 47806c8) * Standardize copyright years (#1227) * Standardize copyright years * Use hard-coded year in conf.py, for ease of later search-and-replace. Also normalise punctuation. * More punctuation OCD * More consistency fixes * Remove unused import * Remove the _right_ unused import * Yet one more consistency fix (cherry picked from commit aa63531) * Don't mutate global state at import time in a test module (#1222) (cherry picked from commit 24345a1) * Fix typo in optional_dependencies (#1235) Fix a comment that mistakenly refers to traits.api, when it means traitsui.api. (cherry picked from commit a48ede5) * Update PyPI links and capitalization in README.rst (#1250) * Update PyPI links and capitalization in README.rst This PR: - updates incorrect and inconsistent capitalization in the README - adds a PyPI link for Sphinx - adds a PyPI link for the Enthought Sphinx Theme (the previous link was to GitHub) * Clarify that later versions of Sphinx are fine * Update README.rst (cherry picked from commit 8d03955) * Update changelog Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com>
mdickinson
added
porting: backported to 6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're mutating global state at import time in a test module, potentially leading to test interactions and test dependence on import order. This PR fixes the test to mutate at
setUptime instead, and undo that mutation attearDown.Fixes #1220.