Use ComparisonMode constants instead of magic numbers #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this PR will conflict with #1165; whichever one gets merged second (probably this one) will need to deal with the merge conflicts. |
kitchoi
approved these changes
Jun 26, 2020
2 tasks
|
Hmm. I somehow lost some of the changes when resolving conflicts. Will fix. |
|
Ah no; I see - there were new cases introduced in #1208. |
4 tasks
mdickinson
commented
Jun 26, 2020
| @@ -417,12 +422,12 @@ class Potato(HasTraits): | |||
|
|
|||
| class PotatoBag(HasTraits): | |||
|
|
|||
| potatos = List(Instance(Potato), comparison_mode=1) | |||
| potatos = List(Instance(Potato), comparison_mode=ComparisonMode.identity) | |||
There was a problem hiding this comment.
I really want to change this to potatoes, but that's out of scope for this PR.
|
Race conditions from a number of PRs. Yes I agree the many |
|
@kitchoi Okay to merge this and look at removing redundant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup PR: replace uses of magic numbers for comparison modes with the corresponding
ComparisonModeelements. (The numbers should eventually become just an implementation detail; we want to encourage all traits users to use theComparisonModeconstants instead.)