Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup comparison mode setting in tests and documentation #1240

Merged
merged 4 commits into from
Jul 13, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Jul 13, 2020

After #1165, we no longer need to set comparison_mode to identity in container traits in order to silence warnings and support observe. This PR cleans up such definitions in tests and documentation.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

@kitchoi
Copy link
Contributor Author

kitchoi commented Jul 13, 2020

Oops, I missed one, typical...

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdickinson mdickinson merged commit 5a96cd4 into master Jul 13, 2020
@mdickinson mdickinson deleted the cleanup-comparison-mode branch July 13, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants