-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up CI builds by caching the pip directory #1241
Conversation
First Travis CI build: Ran for 13 min 26 sec; Total time 19 min 31 sec |
Second build was better: Ran for 8 min 54 sec; Total time 18 min 59 sec |
I'll see if I can add caching for appveyor, too. Waiting for the current build to finish first. |
Scratch that; it was taking too long. We still expect the next Appveyor build to be slow. The one after that should be faster. |
The uncached Appveyor build took 20 min 38 sec. Have restarted. |
Caching is now working on both Travis and Appveyor. It's not having a huge effect on Appveyor: we're down to around 17 minutes from 20 minutes, but it's better than nothing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two questions.
@@ -3,6 +3,8 @@ dist: xenial | |||
services: | |||
- xvfb | |||
|
|||
cache: pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if im not wrong, this means ~/.cache/pip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, $HOME/.cache/pip
, according to the documentation
@@ -1,5 +1,8 @@ | |||
build: false | |||
|
|||
cache: | |||
- C:\Users\appveyor\AppData\Local\pip\Cache -> appveyor.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i'm not wrong, this means that the cache will be invalidated if the appveyor yaml file is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This gives us an easy way to invalidate the cache should we need to.
A trivial build PR to cache pip eggs.
I plan to run the CI build twice: if this worked, the second run should be appreciably faster than that first.