Make TraitListEvent arguments keyword only #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
LGTM, though it's a bit awkward with respect to dependencies: it'll effectively make Traits 6.2.0 and TraitsUI 7.0.0 a no-go combination. But I think that's okay. |
That should be fine. I think there may be other incompatibilities around the Font and Color traits with that combination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1035
This PR makes the
TraitListEventarguments keyword only to match what is done forTraitSetEventandTraitDictEvent, and for safety.Checklist
- [ ] Update API reference (docs/source/traits_api_reference)- [ ] Update User manual (docs/source/traits_user_manual)- [ ] Update type annotation hints intraits-stubs