Make traits.examples into a package #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and update setup.py accordingly
mdickinson
reviewed
Nov 16, 2020
mdickinson
approved these changes
Nov 16, 2020
|
I've changed the branch protections to not require Travis CI (but those changes aren't backed up in terraform). Closing and re-opening to retrigger CI. |
|
Slack discussion says that Travis CI should be working again. Closing and re-opening to test that statement. |
|
@kitchoi Okay to merge this once CI signs off? |
And the test failed. But that shouldn't prevent merging this PR. |
kitchoi
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1302
In this PR, an
__init__.pyfile is added totraits.examplesto make it a package,_entry_point.pyis renamed_etsdemo_info.pyand moved into the package with thesetup.pyentry point updated accordingly, and a very simple test is added for theintroductionfunction in_etsdemo_info.py(I wasn't exactly sure what all we would want to test here). Also thepkg_resourceimport is moved inside theintroductionfunction as mentioned on the issue.I confirmed that I could launch the etsdemo application and still see the contributed examples.
Checklist
- [ ] Update API reference (docs/source/traits_api_reference)- [ ] Update User manual (docs/source/traits_user_manual)- [ ] Update type annotation hints intraits-stubs