Add errors for PrefixList, PrefixMap, and Map with empty lists/dicts #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty list/dictionaries and add tests for these errors
mdickinson
reviewed
Nov 16, 2020
traits/trait_types.py
Outdated
| else: | ||
| raise ValueError( | ||
| "The dictionary of valid values can not be empty." | ||
| ) |
There was a problem hiding this comment.
You may want to make this a raise ... from None, so that we the KeyError doesn't show up in the traceback.
mdickinson
approved these changes
Nov 16, 2020
|
LGTM! Waiting for CI, then I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1191
PrefixList, previously if no default was given and the given list of strings was empty, had a default default value ofNone. In this PR, if the given list toPrefixListis empty an error is raised. Likewise, ifMaporPrefixMapare fed empty dicts aValueErroris also raised. Previously, forMapandPrefixMapif an empty dictionary was given, it would raise aStopIterationexception. In this PR that is changed to aValueErrorwith a message explicitly specifying that the dictionary of valid values can not be empty.Additionally, this PR adds trivial tests to ensure errors are raised when empty lists/dictionaries are used.
Checklist
- [ ] Update API reference (docs/source/traits_api_reference)- [ ] Update User manual (docs/source/traits_user_manual)- [ ] Update type annotation hints intraits-stubs