-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make allow_none functional in the Date
trait type
#1432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Feb 4, 2021
mdickinson
commented
Feb 4, 2021
mdickinson
commented
Feb 4, 2021
mdickinson
commented
Feb 4, 2021
rahulporuri
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to prevent assignment of
None
to aDate
trait. (As usual, it doesn't prevent a default value ofNone
.)Note that before the recently-merged PR #1429,
Date
was an instance ofBaseInstance
, and so in theory should already have allowed and respectedallow_none
. But a different bug (#495) means thatallow_none
was not respected. So this PR actually introduces a change in behaviour (effectively a bugfix) for anyone already doing:foo = Date(allow_none=False)
: before this PR, assignment ofNone
would still have been permitted for such a trait declaration. After this PR, it won't be.In detail, we:
allow_none
toDate
, defaulting toTrue
for backwards compatibility reasonsNone
ifallow_none
isFalse
Checklist
[ ] Update API reference (N/Adocs/source/traits_api_reference
)[ ] Update User manual (N/Adocs/source/traits_user_manual
)traits-stubs