Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the docstring for HasTraits.trait_get #1465

Merged
merged 4 commits into from
May 18, 2021

Conversation

mdickinson
Copy link
Member

Rival PR to #1453. This PR rewrites the docstring for HasTraits.trait_get to better explain the various different (and conflicting) ways it can be used.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 20d9af1 into master May 18, 2021
@mdickinson mdickinson deleted the doc/has-traits-trait-get branch May 18, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants