Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration file for Read the Docs #1478

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Conversation

mdickinson
Copy link
Member

This PR adds a basic configuration file for Read the Docs. This file was sufficient to get the RtD build passing. See https://traits.readthedocs.io/en/docs-readthedocs-config/ for the documentation built from this branch.

@rahulporuri rahulporuri self-requested a review July 1, 2021 16:16
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The built docs on readthedocs look good to me.

Comment on lines +9 to +12
- method: pip
path: .
extra_requirements:
- docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this means python -m pip install .[docs]? It's not clear from the docs page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I think there's an example in the RtD docs that makes this somewhat clear, but you're right that it doesn't seem to be spelled out explicitly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, I was looking at the bit just after the text "With the previous settings, Read the Docs will execute the next commands:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants