Deprecate the clean_filename and clean_timestamp utilities #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Sep 16, 2021
mdickinson
deleted the
clean/deprecate-clean-filename-clean-timestamp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clean_filenameandclean_timestamputility functions have nothing to do with Traits and are not documented or exposed in any of theapimodules; additionally,clean_timestamphas no tests. This PR deprecates those functions, so that they can be removed in Traits 7.0.0.A check of ETS and private ETS-using projects that I have access to turned up no uses of either function.
Closes #1447.
Checklist