MAINT: replace deprecated version check for traitsui #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed a new test error happened: So is this deprecation error supposed to be there to be check by another test (in MacOS, this deprecation error will cause the full unittest to fail)? |
|
The issue is that the test still relies on the deprecated way to set the version: You'll need to adapt the mock to properly change the version. |
|
Thanks for looking at this, @homosapien-lcy. Actually, I think we can simply remove the version check and the test for it. This was an interim measure that was needed at some point in the past when Traits had a stronger dependence on TraitsUI than it does now. |
Got it, I remove all version checks for this PR |
Closed
mdickinson
pushed a commit
that referenced
this pull request
Jul 10, 2023
In traitsui, traitsui.__version__ has been deprecated and should be
replaced with importlib.metadata.version('traitsui'). The deprecation
warning raised have also caused test_edit_not_given in
traits/traits/tests/test_configure_traits.py to fail as mentioned in
#1745 . Since the version check is a temporary check to address the
dependency of traits on traits ui and is no longer need, the current PR
fixed this issue by removing all version checks related to
_traitsui_helpers.py.
Closes #1745
Co-authored-by: Chengyu Liu <cyliu@aus552cyliu.local>
Closed
mdickinson
pushed a commit
that referenced
this pull request
Jul 26, 2023
In traitsui, traitsui.__version__ has been deprecated and should be
replaced with importlib.metadata.version('traitsui'). The deprecation
warning raised have also caused test_edit_not_given in
traits/traits/tests/test_configure_traits.py to fail as mentioned in
#1745 . Since the version check is a temporary check to address the
dependency of traits on traits ui and is no longer need, the current PR
fixed this issue by removing all version checks related to
_traitsui_helpers.py.
Closes #1745
Co-authored-by: Chengyu Liu <cyliu@aus552cyliu.local>
(cherry picked from commit 60f918e)
mdickinson
pushed a commit
that referenced
this pull request
Jul 26, 2023
In traitsui, traitsui.__version__ has been deprecated and should be
replaced with importlib.metadata.version('traitsui'). The deprecation
warning raised have also caused test_edit_not_given in
traits/traits/tests/test_configure_traits.py to fail as mentioned in
#1745 . Since the version check is a temporary check to address the
dependency of traits on traits ui and is no longer need, the current PR
fixed this issue by removing all version checks related to
_traitsui_helpers.py.
Closes #1745
Co-authored-by: Chengyu Liu <cyliu@aus552cyliu.local>
(cherry picked from commit 60f918e)
mdickinson
added a commit
that referenced
this pull request
Aug 7, 2023
This PR (against the maint/6.4 branch) is aimed at a 6.4.2 bugfix release. Key changes: - Backport PR #1746 - Backport PR #1749 - Update copyright headers and bring CI back to working state - Update changelog, bump version for release. The PR is pretty horrendous to review en masse thanks to the changelog updates, but it should be possible to review it commit by commit. @corranwebster Would you have bandwidth for review at some point? (Feel free to unassign if not.) --------- Co-authored-by: homosapien-lcy <102019577+homosapien-lcy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In traitsui, traitsui.version has been deprecated and should be replaced with importlib.metadata.version('traitsui'). The deprecation warning raised have also caused test_edit_not_given in traits/traits/tests/test_configure_traits.py to fail as mentioned in #1745 . Since the version check is a temporary check to address the dependency of traits on traits ui and is no longer need, the current PR fixed this issue by removing all version checks related to _traitsui_helpers.py. closes #1745
Checklist
docs/source/traits_api_reference) (only replacing a deprecated version check, no change in behavior)docs/source/traits_user_manual) (only replacing a deprecated version check, no change in behavior)