Small fixes for the Cython branch

[jvkersch]

• Master merge;
• Fixes the issue raised by @pberkes;
• Various small fixes to address compiler warnings.

[pberkes]

I'm getting new test failures, this time with

  File "/Users/pberkes/egit/traits/traits/has_traits.py", line 2797, in add_trait
    old_trait = self._trait( name, 0 )
  File "traits/ctraits.pyx", line 1054, in traits.ctraits.CHasTraits._trait (traits/ctraits.c:12235)
TypeError: Expected str, got unicode
ERROR

I'll try to come up with a minimal example.

[pberkes]

And this:

  File "traits/ctraits.pyx", line 886, in traits.ctraits.CHasTraits.__getattr__ (traits/ctraits.c:10188)
    value = trait.getattr(trait, self, name)
  File "traits/ctraits.pyx", line 1354, in traits.ctraits.getattr_delegate (traits/ctraits.c:16531)
    raise exc
NotImplementedError: getattr disallow NOT IMPL.

[pberkes]

And several failures due to change event not firing.

[mdickinson]

Tentatively assigning to milestone 5.0.

@jvkersch, @dpinte: Do you have a feeling for how much work is left to get this into a state where we can run major projects against it without problems?

[mdickinson]

Sorry, wrong PR; I meant to add the main Cython PR to Milestone 5.

[mdickinson]

@pberkes: Does "new test failures" mean new with this particular PR? Or do those tests already fail on the enh/cython-port branch?

[pberkes]

I don't know if it's the same tests failing, but the errors are different.

[mdickinson]

I don't know if it's the same tests failing, but the errors are different.

Okay. I'd suggest merging this PR (changes LGTM), and addressing the new test failures in a separate one.

[pberkes]

+1