Cython port: handle Disallow #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,6 +157,25 @@ cdef object invalid_attribute_error(): | |||
|
|
|||
| raise TypeError('Attribute name must be a string.') | |||
|
|
|||
| cdef object unknown_attribute_error(obj, name): | |||
There was a problem hiding this comment.
It looks like you're adjusting the code to (roughly) follow PEP8. If that's the case, there should probably be an extra blank line above.
|
Changes LGTM. One nit, and one discussion point w.r.t. |
|
@dpinte @mdickinson Thanks for the review. I've added the PEP8 blank line and opened an issue for the ctraits.c issue. I'll merge when Travis goes green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #312.