-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDM-less continuous integration #878
Conversation
This reverts commit 2a450e6.
This was just a proof of concept, and @corranwebster has a more complete solution in the works. Closing. |
…ures on Python 3.9
This is now ready for review. Note that we only test one version of Python on macOS; testing multiple versions of Python on macOS seems to be hard to do. (Using Given that we have good coverage of Python versions on Linux (3.5 through 3.9), I think that's good enough. |
This needs a master merge for the Will merge (master into this branch), then observe and fix the breakage. |
Well, that's not the failure I was expecting:
Looks like a new version of Sphinx was released recently, and it breaks the trait-documenter. I've opened #1205 to track this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. One question and etstool.py install
is failing on this branch...
edm.yaml
Outdated
repositories: | ||
- enthought/free | ||
- enthought/lgpl | ||
- enthought/gpl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
etstool.py install
fails because this file is removed. We probably need to keep this for now or etstool.py
will need to be updated accordingly. Probably easiest to keep this file and worry about the future of etstool.py
separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've added it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. We shouldn't actually need enthought/lgpl
or enthought/gpl
here, but as you say, this can be changed in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for reviewing! |
EDIT: Currently blocked by #1205 (which is fixed in #1206).This PR updates the continuous integration to avoid using etstool.py and EDM.
Closes #687
Main advantages:
Disadvantages
as currently written, this only runs tests against a local dev install, not against a proper install; errors due to missing package_data won't be detected. This could be fixed.Still to do: