Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PrefixMap #953

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Refactor PrefixMap #953

merged 1 commit into from
Mar 23, 2020

Conversation

midhun-pm
Copy link
Contributor

@midhun-pm midhun-pm commented Mar 21, 2020 •
edited

Checklist
- [ ] Tests Exists
- [ ] Update API reference (docs/source/traits_api_reference) Remains the same.
- [ ] Update User manual (docs/source/traits_user_manual) Had no mention of if.

  • Update type annotation hints in traits-stubs

This PR fixes #952

  • Refactors the PrefixMap class to inherit from TraitType instead of Map
  • Removes fast validation for PrefixMap

@mdickinson
Copy link
Member

Had no mention of if.

I guess we should fix that. :-) (But not necessarily in this PR.)

@mdickinson
Copy link
Member

I guess we should fix that.

Opened #954

mdickinson
mdickinson approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 26548b0 into master Mar 23, 2020
@mdickinson mdickinson deleted the refactor/PrefixMap branch March 23, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor PrefixMap
2 participants
@midhun-pm @mdickinson