Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Map, PrefixMap and PrefixList to the User manual #970

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

midhun-pm
Copy link
Contributor

@midhun-pm midhun-pm commented Mar 30, 2020

PR documents the Map, PrefixMap and PrefixList in the user manual.
Fixes #954

Checklist
- [ ] Tests
- [ ] Update API reference (docs/source/traits_api_reference)

  • Update User manual (docs/source/traits_user_manual)
    - [ ] Update type annotation hints in traits-stubs

@mdickinson
Copy link
Member

Appveyor failure was unrelated; I've restarted the job.

@kitchoi Would you be willing to review?

@mdickinson mdickinson requested a review from kitchoi April 1, 2020 09:01
Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Just some minor requests.

docs/source/traits_user_manual/defining.rst Outdated Show resolved Hide resolved
docs/source/traits_user_manual/defining.rst Outdated Show resolved Hide resolved
docs/source/traits_user_manual/defining.rst Outdated Show resolved Hide resolved
docs/source/traits_user_manual/defining.rst Outdated Show resolved Hide resolved
@midhun-pm
Copy link
Contributor Author

@kitchoi Thanks for the review. Made the changes.

Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@midhun-pm midhun-pm merged commit 6f58511 into master Apr 2, 2020
@midhun-pm midhun-pm deleted the docs/map_prefix_map_prefix_list branch April 2, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User documentation for PrefixList, PrefixMap and Map
3 participants