-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example class OddInt #973
Conversation
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 73.02% 73.20% +0.18%
==========================================
Files 51 51
Lines 6505 6497 -8
Branches 1307 1305 -2
==========================================
+ Hits 4750 4756 +6
+ Misses 1364 1350 -14
Partials 391 391
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Looks good (modulo one nitpick).
There are a couple of other places in new_types.py
, that have the OddInt(Int)
example in docstrings. Could we update those, too?
Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Checklist
- [ ] Tests- [ ] Update API reference (docs/source/traits_api_reference
)docs/source/traits_user_manual
)- [ ] Update type annotation hints intraits-stubs
PR fixes #486
Make the
OddInt
example class inherit fromBaseInt
which does not have a fast validator.