Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example class OddInt #973

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Fix example class OddInt #973

merged 3 commits into from
Apr 2, 2020

Conversation

midhun-pm
Copy link
Contributor

@midhun-pm midhun-pm commented Mar 31, 2020

Checklist
- [ ] Tests
- [ ] Update API reference (docs/source/traits_api_reference)

  • Update User manual (docs/source/traits_user_manual)
    - [ ] Update type annotation hints in traits-stubs

PR fixes #486
Make the OddInt example class inherit from BaseInt which does not have a fast validator.

@codecov-io
Copy link

codecov-io commented Mar 31, 2020

Codecov Report

Merging #973 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   73.02%   73.20%   +0.18%     
==========================================
  Files          51       51              
  Lines        6505     6497       -8     
  Branches     1307     1305       -2     
==========================================
+ Hits         4750     4756       +6     
+ Misses       1364     1350      -14     
  Partials      391      391              
Impacted Files Coverage Δ
traits/editor_factories.py 79.59% <0.00%> (-9.19%) ⬇️
traits/trait_base.py 62.98% <0.00%> (-0.60%) ⬇️
traits/trait_types.py 71.57% <0.00%> (+0.07%) ⬆️
traits/traits.py 76.92% <0.00%> (+4.04%) ⬆️
traits/etsconfig/etsconfig.py 63.46% <0.00%> (+6.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca847f...99ba62d. Read the comment docs.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks good (modulo one nitpick).

There are a couple of other places in new_types.py, that have the OddInt(Int) example in docstrings. Could we update those, too?

@midhun-pm
Copy link
Contributor Author

Changed Int to BaseInt in new_types.py also.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mdickinson mdickinson merged commit dd7bc44 into master Apr 2, 2020
@mdickinson mdickinson deleted the bugfix/fix_oddint_example branch April 2, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OddInt example failed due to validation done by fast_validate
3 participants