Skip to content

Commit

Permalink
Removing page paramter which doesn't seem to work.
Browse files Browse the repository at this point in the history
Signed-off-by: rick <technoweenie@gmail.com>
  • Loading branch information
jqr authored and technoweenie committed Apr 20, 2009
1 parent d478f2b commit 6aaeef1
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions lib/seinfeld/models.rb
Expand Up @@ -26,7 +26,7 @@ class << self
attr_accessor :github_password
end

self.feed_format = "http://github.com/%s.atom?page=%d"
self.feed_format = "http://github.com/%s.atom"

include DataMapper::Resource
property :id, Integer, :serial => true
Expand Down Expand Up @@ -124,9 +124,9 @@ def update_progress
end
end

def committed_days_in_feed(page = 1)
def committed_days_in_feed
Time.zone = time_zone || "UTC"
feed = get_feed(page)
feed = get_feed
return nil if feed.nil?
entry_id = nil # track the first entry id to store in the user model
skipped_early = nil
Expand All @@ -138,7 +138,6 @@ def committed_days_in_feed(page = 1)
entry_id ||= this_entry_id
if last_entry_id == this_entry_id
debug "stopping because #{last_entry_id} == #{this_entry_id}"
skipped_early = true
break selected
end

Expand All @@ -150,11 +149,6 @@ def committed_days_in_feed(page = 1)
selected
end
end.keys
unless skipped_early
self.last_entry_id = entry_id
days += committed_days_in_feed(page += 1)
days.uniq!
end
days
end

Expand Down Expand Up @@ -195,10 +189,10 @@ def self.process_new_github_user(subject)
end

private
def get_feed(page = 1)
debug "loading feed: " + self.class.feed_format % [login, page]
def get_feed
debug "loading feed: " + self.class.feed_format % login
feed = nil
open(self.class.feed_format % [login, page]) { |f| feed = FeedMe.parse(f.read) }
open(self.class.feed_format % login) { |f| feed = FeedMe.parse(f.read) }
feed
rescue
nil
Expand Down

0 comments on commit 6aaeef1

Please sign in to comment.