Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#68): handle NaN in Point shape #70

Merged

Conversation

bernardobelchior
Copy link
Contributor

@bernardobelchior bernardobelchior commented Mar 22, 2022

If a NaN value is passed to a Point shape, it will now avoid painting anything. Fixes #68.

Note: point is a Offset, which has a isFinite method that checks if both coordinates are finite.

If a NaN value is passed to a Point shape, it will now avoid
painting anything.
@bernardobelchior bernardobelchior marked this pull request as ready for review March 22, 2022 09:29
@entronad entronad merged commit 72b9b32 into entronad:main Mar 22, 2022
@bernardobelchior bernardobelchior deleted the fix/handle-nan-in-point-shape branch March 22, 2022 09:33
@entronad
Copy link
Owner

entronad commented Apr 5, 2022

Published in v0.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point does not handle double.nan values
2 participants